2010-12-15 13:43:31 +01:00
|
|
|
[ ] Enforce valid parameters.
|
2010-07-03 12:06:34 +02:00
|
|
|
Some functions will cause a crash when called with invalid parameters (e.g.
|
|
|
|
|
mifare_classic_authenticate() with a NULL key).
|
2010-12-15 13:43:31 +01:00
|
|
|
[ ] MAD and MifareApplication functions are tied to mifare_clasic_* ones and
|
2010-07-03 12:06:34 +02:00
|
|
|
some refactoring is required to have a consistent API.
|
2010-12-15 13:43:31 +01:00
|
|
|
[ ] The DESFIRE_TRANSCEIVE macro should be replaced by a function
|
|
|
|
|
DESFIRE_TRANSCEIVE was originaly a macro to enclose a nfc_initiator_trans-
|
|
|
|
|
ceive_bytes() call with debug lines. The functions has unexpectedly grown
|
|
|
|
|
up and is now between 25 and 100 lines of code (depending of my refactoring
|
|
|
|
|
mood). The main drawbacks are poor readability, redundant code in the
|
|
|
|
|
binary, debuggers don't cope well with macros, and by design it sucks.
|
