crewID/libfreefare
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Check Mifare Classic command return values.

Browse source 
Many command return 1 byte, and my documentation does not tell what it's
supposed to be. However, this byte is always 0 when running the regression test
suite.  It's likely to be an error code with value 0 being a no-error code.
Assume this and check that the returned byte is always 0.
This commit is contained in:
Romain Tartiere 2010-08-31 11:29:29 +00:00
parent be45b25965
commit a5f1a80447
1 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
libfreefare/mifare_classic.c
View file

@ -285,8 +285,7 @@ mifare_classic_authenticate (MifareTag tag, const MifareClassicBlockNumber block
MIFARE_CLASSIC(tag)->cached_access_bits.sector_access_bits = 0x00;
MIFARE_CLASSIC(tag)->last_authentication_key_type = key_type;
// No result. The MIFARE tag just ACKed.
return 0;
return (res[0] == 0) ? 0 : -1;
}
/*
@ -378,8 +377,7 @@ mifare_classic_write (MifareTag tag, const MifareClassicBlockNumber block, const
CLASSIC_TRANSCEIVE (tag, cmd, res);
// No result. The MIFARE tag just ACKed.
return 0;
return (res[0] == 0) ? 0 : -1;
}
/*
@ -401,8 +399,7 @@ mifare_classic_increment (MifareTag tag, const MifareClassicBlockNumber block, c
CLASSIC_TRANSCEIVE (tag, cmd, res);
// No result. The MIFARE tag just ACKed.
return 0;
return (res[0] == 0) ? 0 : -1;
}
/*
@ -424,8 +421,7 @@ mifare_classic_decrement (MifareTag tag, const MifareClassicBlockNumber block, c
CLASSIC_TRANSCEIVE (tag, cmd, res);
// No result. The MIFARE tag just ACKed.
return 0;
return (res[0] == 0) ? 0 : -1;
}
/*
@ -454,8 +450,7 @@ mifare_classic_restore (MifareTag tag, const MifareClassicBlockNumber block)
CLASSIC_TRANSCEIVE (tag, cmd, res);
// No result. The MIFARE tag just ACKed.
return 0;
return (res[0] == 0) ? 0 : -1;
}
/*
@ -475,8 +470,7 @@ mifare_classic_transfer (MifareTag tag, const MifareClassicBlockNumber block)
CLASSIC_TRANSCEIVE (tag, cmd, res);
// FIXME: The receive command returns data. Should be checked.
return 0;
return (res[0] == 0) ? 0 : -1;
}