From 301d692e8a635c9ec2d2dc96fc53fa1d8168f3cc Mon Sep 17 00:00:00 2001 From: Romain Tartiere Date: Sat, 31 Jul 2010 14:02:46 +0000 Subject: [PATCH] Flag references to deprecated usage of pn53x_transceive(). New issue Summary: pn53x_transceive() workaround reverences in examples/nfc-poll.c comments Status: New Owner: rconty@il4p.fr Cc: rtartiere@il4p.fr The source code of nfc-poll has references to no using pn53x_transceive() for the status-byte workaround reason in a comment. However this function is not called in the code. While I guess that's some comment that should have been removed and have never reached the svn repo, I prefer to be sure that it can be removed. The comments where introduced at the same time of the file, at r353. --- examples/nfc-poll.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/nfc-poll.c b/examples/nfc-poll.c index 9c70859..905246b 100644 --- a/examples/nfc-poll.c +++ b/examples/nfc-poll.c @@ -94,6 +94,7 @@ main (int argc, const char *argv[]) printf ("Connected to NFC reader: %s\n", pnd->acName); // NOTE we can't use pn53x_transceive() because rx[0] is not status byte (0x00 != status OK) +// XXX: as of r491, this is no longer the case. Unfortunately I can't be sure that these comments can be removed. // bool pn53x_transceive(const nfc_device_t* pnd, const byte_t* pbtTx, const size_t szTxLen, byte_t* pbtRx, size_t* pszRxLen); // bool res = pn53x_transceive(pnd, abtTx, szTxLen, abtRx, &szRxLen);