From 7113d1418bc2f0c1f04c556d57db2a3dfc6ac7c1 Mon Sep 17 00:00:00 2001 From: Romuald Conty Date: Fri, 30 Jul 2010 11:45:59 +0000 Subject: [PATCH] Add FIXME to raise an E_NOTSUPPORTED error in future, New issue Summary: Catch unsupported command before sending to chip Labels: Milestone-1.6.x Actually, libnfc support PN531, PN532 and PN533 NFC chips, but the devices does not the same features. e.g. PN531 does not support ISO14443B modulation. It should great to catch theses unsuported commands before sending to chip in order to prevent a chip error. --- libnfc/chips/pn53x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libnfc/chips/pn53x.c b/libnfc/chips/pn53x.c index a56d37d..2ee216b 100644 --- a/libnfc/chips/pn53x.c +++ b/libnfc/chips/pn53x.c @@ -298,6 +298,7 @@ pn53x_InListPassiveTarget(const nfc_device_t* pnd, byte_t abtCmd[sizeof(pncmd_initiator_list_passive)]; memcpy(abtCmd,pncmd_initiator_list_passive,sizeof(pncmd_initiator_list_passive)); + // FIXME PN531 doesn't support all available modulations abtCmd[2] = szMaxTargets; // MaxTg abtCmd[3] = nmInitModulation; // BrTy, the type of init modulation used for polling a passive tag