From a5e7dec797631ad8eebedca0144451c34211a49a Mon Sep 17 00:00:00 2001 From: Philippe Teuwen Date: Fri, 20 Sep 2013 00:01:41 +0200 Subject: [PATCH] Initialize array to keep Coverity happy as Coverity fails seeing that szTargetTypes will always be = 0 in the case believed to lead to reading unitialized data in apttTargetTypes. CID 1090347 (#1 of 1): Uninitialized scalar variable (UNINIT) 4. uninit_use_in_call: Using uninitialized element of array "apttTargetTypes" when calling "pn53x_InAutoPoll(struct nfc_device *, pn53x_target_type const *, size_t const, uint8_t const, uint8_t const, nfc_target *, int const)". --- libnfc/chips/pn53x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libnfc/chips/pn53x.c b/libnfc/chips/pn53x.c index c5aec26..7f142f7 100644 --- a/libnfc/chips/pn53x.c +++ b/libnfc/chips/pn53x.c @@ -1184,6 +1184,7 @@ pn53x_initiator_poll_target(struct nfc_device *pnd, if (CHIP_DATA(pnd)->type == PN532) { size_t szTargetTypes = 0; pn53x_target_type apttTargetTypes[32]; + memset(apttTargetTypes, PTT_UNDEFINED, 32); for (size_t n = 0; n < szModulations; n++) { const pn53x_target_type ptt = pn53x_nm_to_ptt(pnmModulations[n]); if (PTT_UNDEFINED == ptt) {