Merge pull request #504 from AdamLaurie/master

Fix handling of NTAG OTP and LOCK bytes
This commit is contained in:
Philippe Teuwen 2018-09-18 16:36:13 +02:00 committed by GitHub
commit a9af1927e6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 70 additions and 36 deletions

View file

@ -242,11 +242,12 @@ typedef struct {
} mifareul_ev1_mf0ul11_tag; } mifareul_ev1_mf0ul11_tag;
// UL EV1 MF0UL21 tag - 1 manuf block + 8 user blocks + 1/4 lock block + 1 config block // UL EV1 MF0UL21 tag - 1 manuf block + 8 user blocks + 1/4 lock block + 1 config block
// (note that tag is actually 3 bytes smaller due to 1/4 block, so don't rely on this for sizing!)
typedef struct { typedef struct {
mifareul_block amb[11]; mifareul_block amb[11];
} mifareul_ev1_mf0ul21_tag; } mifareul_ev1_mf0ul21_tag;
// NOT really UL but so similar we can re-use this code // NTAG is a range of NXP tags some of which are essentially Ultralights so we can support them here
// if Edwin van Andel doesn't distract us... // if Edwin van Andel doesn't distract us...
// https://www.nxp.com/docs/en/data-sheet/NTAG213_215_216.pdf // https://www.nxp.com/docs/en/data-sheet/NTAG213_215_216.pdf

View file

@ -64,9 +64,11 @@
#define EV1_NONE 0 #define EV1_NONE 0
#define EV1_UL11 1 #define EV1_UL11 1
#define EV1_UL21 2 #define EV1_UL21 2
#define EV1_NTAG213 3
#define EV1_NTAG215 4 #define NTAG_NONE 0
#define EV1_NTAG216 5 #define NTAG_213 1
#define NTAG_215 2
#define NTAG_216 3
static nfc_device *pnd; static nfc_device *pnd;
static nfc_target nt; static nfc_target nt;
@ -77,6 +79,7 @@ static uint32_t uiReadPages = 0;
static uint8_t iPWD[4] = { 0x0 }; static uint8_t iPWD[4] = { 0x0 };
static uint8_t iPACK[2] = { 0x0 }; static uint8_t iPACK[2] = { 0x0 };
static uint8_t iEV1Type = EV1_NONE; static uint8_t iEV1Type = EV1_NONE;
static uint8_t iNTAGType = NTAG_NONE;
// special unlock command // special unlock command
uint8_t abtUnlock1[1] = { 0x40 }; uint8_t abtUnlock1[1] = { 0x40 };
@ -144,19 +147,25 @@ read_card(void)
memcpy(mtDump.ul[9].mbc21a.pwd, iPWD, 4); memcpy(mtDump.ul[9].mbc21a.pwd, iPWD, 4);
memcpy(mtDump.ul[9].mbc21b.pack, iPACK, 2); memcpy(mtDump.ul[9].mbc21b.pack, iPACK, 2);
break; break;
case EV1_NTAG213: case EV1_NONE:
default:
break;
}
// copy NTAG secrets to dump data
switch (iNTAGType) {
case NTAG_213:
memcpy(mtDump.nt[43].mbc21356d.pwd, iPWD, 4); memcpy(mtDump.nt[43].mbc21356d.pwd, iPWD, 4);
memcpy(mtDump.nt[44].mbc21356e.pack, iPACK, 2); memcpy(mtDump.nt[44].mbc21356e.pack, iPACK, 2);
break; break;
case EV1_NTAG215: case NTAG_215:
memcpy(mtDump.nt[133].mbc21356d.pwd, iPWD, 4); memcpy(mtDump.nt[133].mbc21356d.pwd, iPWD, 4);
memcpy(mtDump.nt[134].mbc21356e.pack, iPACK, 2); memcpy(mtDump.nt[134].mbc21356e.pack, iPACK, 2);
break; break;
case EV1_NTAG216: case NTAG_216:
memcpy(mtDump.nt[229].mbc21356d.pwd, iPWD, 4); memcpy(mtDump.nt[229].mbc21356d.pwd, iPWD, 4);
memcpy(mtDump.nt[230].mbc21356e.pack, iPACK, 2); memcpy(mtDump.nt[230].mbc21356e.pack, iPACK, 2);
break; break;
case EV1_NONE: case NTAG_NONE:
default: default:
break; break;
} }
@ -330,7 +339,7 @@ static bool check_magic()
} }
static bool static bool
write_card(bool write_otp, bool write_lock, bool write_uid) write_card(bool write_otp, bool write_lock, bool write_dyn_lock, bool write_uid)
{ {
uint32_t uiBlock = 0; uint32_t uiBlock = 0;
bool bFailure = false; bool bFailure = false;
@ -341,21 +350,31 @@ write_card(bool write_otp, bool write_lock, bool write_uid)
char buffer[BUFSIZ]; char buffer[BUFSIZ];
if (!write_otp) { if (!write_otp) {
printf("Write OTP bytes ? [yN] "); printf("Write OTP/Capability Bytes ? [yN] ");
if (!fgets(buffer, BUFSIZ, stdin)) { if (!fgets(buffer, BUFSIZ, stdin)) {
ERR("Unable to read standard input."); ERR("Unable to read standard input.");
} }
write_otp = ((buffer[0] == 'y') || (buffer[0] == 'Y')); write_otp = ((buffer[0] == 'y') || (buffer[0] == 'Y'));
} }
// Lock Bytes are OTP if set, so warn
if (!write_lock) { if (!write_lock) {
printf("Write Lock bytes ? [yN] "); printf("Write Lock Bytes (Warning: OTP if set) ? [yN] ");
if (!fgets(buffer, BUFSIZ, stdin)) { if (!fgets(buffer, BUFSIZ, stdin)) {
ERR("Unable to read standard input."); ERR("Unable to read standard input.");
} }
write_lock = ((buffer[0] == 'y') || (buffer[0] == 'Y')); write_lock = ((buffer[0] == 'y') || (buffer[0] == 'Y'));
} }
// NTAG and MF0UL21 have additional lock bytes
if (!write_dyn_lock && (iNTAGType != NTAG_NONE || iEV1Type == EV1_UL21)) {
printf("Write Dynamic Lock Bytes ? [yN] ");
if (!fgets(buffer, BUFSIZ, stdin)) {
ERR("Unable to read standard input.");
}
write_dyn_lock = ((buffer[0] == 'y') || (buffer[0] == 'Y'));
}
if (!write_uid) { if (!write_uid) {
printf("Write UID bytes (only for special writeable UID cards) ? [yN] "); printf("Write UID bytes (only for special writeable UID cards) ? [yN] ");
if (!fgets(buffer, BUFSIZ, stdin)) { if (!fgets(buffer, BUFSIZ, stdin)) {
@ -377,16 +396,26 @@ write_card(bool write_otp, bool write_lock, bool write_uid)
} }
for (uint32_t page = uiSkippedPages; page < uiBlocks; page++) { for (uint32_t page = uiSkippedPages; page < uiBlocks; page++) {
if ((page == 0x2) && (!write_lock)) { if ((!write_lock) && page == 0x2) {
printf("s"); printf("s");
uiSkippedPages++; uiSkippedPages++;
continue; continue;
} }
// OTP/Capability blocks
if ((page == 0x3) && (!write_otp)) { if ((page == 0x3) && (!write_otp)) {
printf("s"); printf("s");
uiSkippedPages++; uiSkippedPages++;
continue; continue;
} }
// NTAG and MF0UL21 have Dynamic Lock Bytes
if (((iEV1Type == EV1_UL21 && page == 0x24) || \
(iNTAGType == NTAG_213 && page == 0x28) || \
(iNTAGType == NTAG_215 && page == 0x82) || \
(iNTAGType == NTAG_216 && page == 0xe2)) && (!write_dyn_lock)) {
printf("s");
uiSkippedPages++;
continue;
}
// Check if the previous readout went well // Check if the previous readout went well
if (bFailure) { if (bFailure) {
// When a failure occured we need to redo the anti-collision // When a failure occured we need to redo the anti-collision
@ -472,10 +501,11 @@ print_usage(const char *argv[])
printf("\tr|w - Perform read or write\n"); printf("\tr|w - Perform read or write\n");
printf("\t<dump.mfd> - MiFare Dump (MFD) used to write (card to MFD) or (MFD to card)\n"); printf("\t<dump.mfd> - MiFare Dump (MFD) used to write (card to MFD) or (MFD to card)\n");
printf("Options:\n"); printf("Options:\n");
printf("\t--otp - Don't prompt for OTP writing (Assume yes)\n"); printf("\t--otp - Don't prompt for OTP Bytes writing (Assume yes)\n");
printf("\t--lock - Don't prompt for Lockbit writing (Assume yes)\n"); printf("\t--lock - Don't prompt for Lock Bytes (OTP) writing (Assume yes)\n");
printf("\t--dynlock - Don't prompt for Dynamic Lock Bytes writing (Assume yes)\n");
printf("\t--uid - Don't prompt for UID writing (Assume yes)\n"); printf("\t--uid - Don't prompt for UID writing (Assume yes)\n");
printf("\t--full - Assume full card write (UID + OTP + Lockbit)\n"); printf("\t--full - Assume full card write (UID + OTP + Lockbytes + Dynamic Lockbytes)\n");
printf("\t--with-uid <UID> - Specify UID to read/write from\n"); printf("\t--with-uid <UID> - Specify UID to read/write from\n");
printf("\t--pw <PWD> - Specify 8 HEX digit PASSWORD for EV1\n"); printf("\t--pw <PWD> - Specify 8 HEX digit PASSWORD for EV1\n");
printf("\t--partial - Allow source data size to be other than tag capacity\n"); printf("\t--partial - Allow source data size to be other than tag capacity\n");
@ -490,6 +520,7 @@ main(int argc, const char *argv[])
size_t szUID = 0; size_t szUID = 0;
bool bOTP = false; bool bOTP = false;
bool bLock = false; bool bLock = false;
bool bDynLock = false;
bool bUID = false; bool bUID = false;
bool bPWD = false; bool bPWD = false;
bool bPart = false; bool bPart = false;
@ -518,11 +549,14 @@ main(int argc, const char *argv[])
} else if (0 == strcmp(argv[arg], "--full")) { } else if (0 == strcmp(argv[arg], "--full")) {
bOTP = true; bOTP = true;
bLock = true; bLock = true;
bDynLock = true;
bUID = true; bUID = true;
} else if (0 == strcmp(argv[arg], "--otp")) { } else if (0 == strcmp(argv[arg], "--otp")) {
bOTP = true; bOTP = true;
} else if (0 == strcmp(argv[arg], "--lock")) { } else if (0 == strcmp(argv[arg], "--lock")) {
bLock = true; bLock = true;
} else if (0 == strcmp(argv[arg], "--dynlock")) {
bDynLock = true;
} else if (0 == strcmp(argv[arg], "--uid")) { } else if (0 == strcmp(argv[arg], "--uid")) {
bUID = true; bUID = true;
} else if (0 == strcmp(argv[arg], "--check-magic")) { } else if (0 == strcmp(argv[arg], "--check-magic")) {
@ -612,36 +646,35 @@ main(int argc, const char *argv[])
} }
printf("\n"); printf("\n");
// test if tag is EV1 // test if tag is EV1 or NTAG
if (get_ev1_version()) { if (get_ev1_version()) {
if (!bPWD) if (!bPWD)
printf("Tag is EV1 - PASSWORD may be required\n"); printf("WARNING: Tag is EV1 or NTAG - PASSWORD may be required\n");
printf("EV1 type: ");
if (abtRx[6] == 0x0b) { if (abtRx[6] == 0x0b) {
printf("MF0UL11 (48 bytes)\n"); printf("EV1 type: MF0UL11 (48 bytes)\n");
uiBlocks = 20; // total number of 4 byte 'pages' uiBlocks = 20; // total number of 4 byte 'pages'
iDumpSize = uiBlocks * 4;
iEV1Type = EV1_UL11; iEV1Type = EV1_UL11;
iDumpSize = sizeof(mifareul_ev1_mf0ul11_tag);
} else if (abtRx[6] == 0x0e) { } else if (abtRx[6] == 0x0e) {
printf("MF0UL21 (128 user bytes)\n"); printf("EV1 type: MF0UL21 (128 user bytes)\n");
uiBlocks = 41; uiBlocks = 41;
iDumpSize = uiBlocks * 4;
iEV1Type = EV1_UL21; iEV1Type = EV1_UL21;
iDumpSize = sizeof(mifareul_ev1_mf0ul21_tag);
} else if (abtRx[6] == 0x0f) { } else if (abtRx[6] == 0x0f) {
printf("NTAG213 (144 user bytes)\n"); printf("NTAG Type: NTAG213 (144 user bytes)\n");
uiBlocks = 45; uiBlocks = 45;
iEV1Type = EV1_NTAG213; iDumpSize = uiBlocks * 4;
iDumpSize = sizeof(mifarentag_213_tag); iNTAGType = NTAG_213;
} else if (abtRx[6] == 0x11) { } else if (abtRx[6] == 0x11) {
printf("NTAG215 (504 user bytes)\n"); printf("NTAG Type: NTAG215 (504 user bytes)\n");
uiBlocks = 135; uiBlocks = 135;
iEV1Type = EV1_NTAG215; iDumpSize = uiBlocks * 4;
iDumpSize = sizeof(mifarentag_215_tag); iNTAGType = NTAG_215;
} else if (abtRx[6] == 0x13) { } else if (abtRx[6] == 0x13) {
printf("NTAG216 (888 user bytes)\n"); printf("NTAG Type: NTAG216 (888 user bytes)\n");
uiBlocks = 231; uiBlocks = 231;
iEV1Type = EV1_NTAG216; iDumpSize = uiBlocks * 4;
iDumpSize = sizeof(mifarentag_216_tag); iNTAGType = NTAG_216;
} else { } else {
printf("unknown! (0x%02x)\n", abtRx[6]); printf("unknown! (0x%02x)\n", abtRx[6]);
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
@ -681,7 +714,7 @@ main(int argc, const char *argv[])
size_t szDump; size_t szDump;
if (((szDump = fread(&mtDump, 1, sizeof(mtDump), pfDump)) != iDumpSize && !bPart) || szDump <= 0) { if (((szDump = fread(&mtDump, 1, sizeof(mtDump), pfDump)) != iDumpSize && !bPart) || szDump <= 0) {
ERR("Could not read from dump file or size mismatch: %s\n", argv[2]); ERR("Could not read from dump file or size mismatch: %s (read %lu, expected %lu)\n", argv[2], szDump, iDumpSize);
fclose(pfDump); fclose(pfDump);
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
} }
@ -719,7 +752,7 @@ main(int argc, const char *argv[])
if (!bRF) if (!bRF)
printf("Warning! Read failed - partial data written to file!\n"); printf("Warning! Read failed - partial data written to file!\n");
} else if (iAction == 2) { } else if (iAction == 2) {
write_card(bOTP, bLock, bUID); write_card(bOTP, bLock, bDynLock, bUID);
} else if (iAction == 3) { } else if (iAction == 3) {
if (!check_magic()) { if (!check_magic()) {
printf("Card is not magic\n"); printf("Card is not magic\n");