crewID/libnfc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

nfc-relay-picc: sleep() expects unsigned int

Browse source 
This avoids Coverity being unhappy that only lower bound was defined, well I hope

lower_bounds: Checking lower bounds of signed scalar "waiting_time" by "waiting_time > 0".
CID 1090343 (#1 of 1): Untrusted value as argument (TAINTED_SCALAR)
  tainted_data: Passing tainted variable "waiting_time" to a tainted sink.
  sleep(waiting_time);
This commit is contained in:
Philippe Teuwen 2013-09-22 03:00:58 +02:00
parent 61884967ea
commit cedbefb880
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
utils/nfc-relay-picc.c
View file

@ -76,7 +76,7 @@ static bool quiet_output = false;
static bool initiator_only_mode = false; static bool initiator_only_mode = false;
static bool target_only_mode = false; static bool target_only_mode = false;
static bool swap_devices = false; static bool swap_devices = false;
static int waiting_time = 0; static unsigned int waiting_time = 0;
FILE *fd3; FILE *fd3;
FILE *fd4; FILE *fd4;
@ -182,12 +182,12 @@ main(int argc, char *argv[])
printf("INFO: %s\n", "Swapping devices."); printf("INFO: %s\n", "Swapping devices.");
swap_devices = true; swap_devices = true;
} else if (0 == strcmp(argv[arg], "-n")) { } else if (0 == strcmp(argv[arg], "-n")) {
if (++arg == argc || (sscanf(argv[arg], "%10i", &waiting_time) < 1)) { if (++arg == argc || (sscanf(argv[arg], "%10u", &waiting_time) < 1)) {
ERR("Missing or wrong waiting time value: %s.", argv[arg]); ERR("Missing or wrong waiting time value: %s.", argv[arg]);
print_usage(argv); print_usage(argv);
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
} }
printf("Waiting time: %i secs.\n", waiting_time); printf("Waiting time: %u secs.\n", waiting_time);
} else { } else {
ERR("%s is not supported option.", argv[arg]); ERR("%s is not supported option.", argv[arg]);
print_usage(argv); print_usage(argv);
@ -466,9 +466,9 @@ main(int argc, char *argv[])
} }
if (ret) { if (ret) {
// Redirect the answer back to the external reader // Redirect the answer back to the external reader
if (waiting_time > 0) { if (waiting_time != 0) {
if (!quiet_output) { if (!quiet_output) {
printf("Waiting %is to simulate longer relay...\n", waiting_time); printf("Waiting %us to simulate longer relay...\n", waiting_time);
} }
sleep(waiting_time); sleep(waiting_time);
} }