From f9391ad8232934f409cc7424016e5b7689441b1f Mon Sep 17 00:00:00 2001 From: Romuald Conty Date: Mon, 18 Oct 2010 15:47:56 +0000 Subject: [PATCH] Update some TODOs --- libnfc/chips/pn53x.c | 3 +-- libnfc/drivers.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/libnfc/chips/pn53x.c b/libnfc/chips/pn53x.c index 82f0a19..f8d3839 100644 --- a/libnfc/chips/pn53x.c +++ b/libnfc/chips/pn53x.c @@ -128,7 +128,7 @@ pn53x_check_ack_frame_callback (nfc_device_t * pnd, const byte_t * pbtRxFrame, c return true; } else if (0 == memcmp (pbtRxFrame, pn53x_nack_frame, sizeof (pn53x_nack_frame))) { DBG ("%s", "PN53x NACKed"); - // TODO: Try to recover + // TODO Try to recover when PN53x NACKs ! // A counter could allow the command to be sent again (e.g. max 3 times) pnd->iLastError = DENACK; return false; @@ -768,7 +768,6 @@ pn53x_get_firmware_version (nfc_device_t * pnd, char abtFirmwareText[18]) { byte_t abtFw[4]; size_t szFwLen = sizeof (abtFw); - // TODO Read more info here: there are modulation capabilities info to know if ISO14443B is supported if (!pn53x_transceive (pnd, pncmd_get_firmware_version, 2, abtFw, &szFwLen)) { // Failed to get firmware revision??, whatever...let's disconnect and clean up and return err pnd->pdc->disconnect (pnd); diff --git a/libnfc/drivers.h b/libnfc/drivers.h index 2afae0f..238c409 100644 --- a/libnfc/drivers.h +++ b/libnfc/drivers.h @@ -82,7 +82,7 @@ static const struct driver_callbacks drivers_callbacks_list[] = { # ifdef DEBUG /* - * FIXME: Helper macro for dumping drivers messages. + * TODO Move this helper macro for dumping drivers messages. * Here is not the best place for such a macro, however, I * can't see any convenient place ATM. */