crewID/libnfc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update some TODOs

Browse source
This commit is contained in:
Romuald Conty 2010-10-18 15:47:56 +00:00
parent 57560c3290
commit f9391ad823
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
libnfc/chips/pn53x.c
View file

@ -128,7 +128,7 @@ pn53x_check_ack_frame_callback (nfc_device_t * pnd, const byte_t * pbtRxFrame, c
return true; return true;
} else if (0 == memcmp (pbtRxFrame, pn53x_nack_frame, sizeof (pn53x_nack_frame))) { } else if (0 == memcmp (pbtRxFrame, pn53x_nack_frame, sizeof (pn53x_nack_frame))) {
DBG ("%s", "PN53x NACKed"); DBG ("%s", "PN53x NACKed");
// TODO: Try to recover // TODO Try to recover when PN53x NACKs !
// A counter could allow the command to be sent again (e.g. max 3 times) // A counter could allow the command to be sent again (e.g. max 3 times)
pnd->iLastError = DENACK; pnd->iLastError = DENACK;
return false; return false;
@ -768,7 +768,6 @@ pn53x_get_firmware_version (nfc_device_t * pnd, char abtFirmwareText[18])
{ {
byte_t abtFw[4]; byte_t abtFw[4];
size_t szFwLen = sizeof (abtFw); size_t szFwLen = sizeof (abtFw);
// TODO Read more info here: there are modulation capabilities info to know if ISO14443B is supported
if (!pn53x_transceive (pnd, pncmd_get_firmware_version, 2, abtFw, &szFwLen)) { if (!pn53x_transceive (pnd, pncmd_get_firmware_version, 2, abtFw, &szFwLen)) {
// Failed to get firmware revision??, whatever...let's disconnect and clean up and return err // Failed to get firmware revision??, whatever...let's disconnect and clean up and return err
pnd->pdc->disconnect (pnd); pnd->pdc->disconnect (pnd);

2
libnfc/drivers.h
View file

@ -82,7 +82,7 @@ static const struct driver_callbacks drivers_callbacks_list[] = {
# ifdef DEBUG # ifdef DEBUG
/* /*
* FIXME: Helper macro for dumping drivers messages. * TODO Move this helper macro for dumping drivers messages.
* Here is not the best place for such a macro, however, I * Here is not the best place for such a macro, however, I
* can't see any convenient place ATM. * can't see any convenient place ATM.
*/ */